Skip to content

TE-16.3 encap_frr_with_reencap_vrf_test.go#5443

Open
cprabha wants to merge 2 commits into
openconfig:mainfrom
cprabha:TE-16.3
Open

TE-16.3 encap_frr_with_reencap_vrf_test.go#5443
cprabha wants to merge 2 commits into
openconfig:mainfrom
cprabha:TE-16.3

Conversation

@cprabha
Copy link
Copy Markdown
Contributor

@cprabha cprabha commented May 11, 2026

In subtest we supposed to create the above "decap+encap" and "lookup in default table" as two separate NHs using different IDs. But a recent script change made them use the same ID, creating a single NH with a subsequent update.

@cprabha cprabha requested a review from a team as a code owner May 11, 2026 22:02
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a configuration issue in the gRIBI test suite where two distinct next hop operations were incorrectly sharing the same index. By assigning a unique index to the decap+encap operation, the test now correctly creates separate next hop entries as intended, preventing unintended updates to existing entries.

Highlights

  • Next Hop Index Correction: Updated the next hop index from 1003 to 1004 to ensure unique identification for the decap+encap operation.
  • Next Hop Group Reference: Updated the next hop group configuration to reference the corrected index 1004 instead of 1003.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates a gRIBI next-hop index from 1003 to 1004. The reviewer recommended replacing the magic number with a named constant to improve code readability and maintainability, as per the Google Go Style Guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants